Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redshift property from BaseObject interface #80

Merged
merged 1 commit into from
Nov 2, 2023
Merged

remove redshift property from BaseObject interface #80

merged 1 commit into from
Nov 2, 2023

Conversation

JoanneBogart
Copy link
Collaborator

There is no reason to include a redshift property in the interface, especially since not all BaseObject subclasses have it.

jchiang87
jchiang87 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@jchiang87 jchiang87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JoanneBogart JoanneBogart merged commit d527f8f into main Nov 2, 2023
1 check passed
@JoanneBogart JoanneBogart deleted the u/jrbogart/remove_redshift_property branch November 2, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchiang87 jchiang87 jchiang87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoanneBogart @jchiang87